fix duplicated classes in bootstrap jar #2347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a packaging issue introduced with #2341.
Classes that are copied as resources are being added to the bootstrap jar, and as a result Jacoco fails due to duplicated bytecode. In practice it might not have any effect at runtime as the classes are loaded by location only and can't be accessed by standard classloaders.
Doing a simple
unzip -l apm-agent-bootstrap/target/apm-agent-bootstrap-1.28.2-SNAPSHOT.jar
shows the issue.Before:
After the change: