tests: refactor handling of config var type in config.test.js (#2313)

No functional change.
elastic · Sep 1, 2021 · 3326b60 · 3326b60
1 parent 60dde8f
commit 3326b60
Showing 1 changed file with 99 additions and 48 deletions.
diff --git a/test/config.test.js b/test/config.test.js
@@ -100,40 +100,74 @@ var truthyValues = [true, 'true']
 
 optionFixtures.forEach(function (fixture) {
   if (fixture[1]) {
-    var bool = typeof fixture[2] === 'boolean'
-    var url = fixture[0] === 'serverUrl' // special case for url's so they can be parsed using url.parse()
-    var file = fixture[0] === 'serverCaCertFile' // special case for files, so a temp file can be written
-    var number = typeof fixture[2] === 'number'
-    var array = Array.isArray(fixture[2])
+    var type
+    if (typeof fixture[2] === 'boolean') {
+      type = 'bool'
+    } else if (fixture[0] === 'serverUrl') {
+      // special case for url's so they can be parsed using url.parse()
+      type = 'url'
+    } else if (fixture[0] === 'serverCaCertFile') {
+      // special case for files, so a temp file can be written
+      type = 'file'
+    } else if (typeof fixture[2] === 'number') {
+      type = 'number'
+    } else if (Array.isArray(fixture[2])) {
+      type = 'array'
+    } else {
+      type = 'string'
+    }
+
     var envName = 'ELASTIC_APM_' + fixture[1]
     var existingValue = process.env[envName]
 
     test(`should be configurable by environment variable ${envName}`, function (t) {
       var agent = new Agent()
       var value
 
-      if (bool) value = !fixture[2]
-      else if (number) value = 1
-      else if (url) value = 'http://custom-value'
-      else if (file) {
-        var tmpdir = path.join(os.tmpdir(), 'elastic-apm-node-test', String(Date.now()))
-        var tmpfile = path.join(tmpdir, 'custom-file')
-        t.on('end', function () { rimraf.sync(tmpdir) })
-        mkdirp.sync(tmpdir)
-        fs.writeFileSync(tmpfile, tmpfile)
-        value = tmpfile
-      } else value = 'custom-value'
+      switch (type) {
+        case 'bool':
+          value = !fixture[2]
+          break
+        case 'number':
+          value = 1
+          break
+        case 'url':
+          value = 'http://custom-value'
+          break
+        case 'file':
+          var tmpdir = path.join(os.tmpdir(), 'elastic-apm-node-test', String(Date.now()))
+          var tmpfile = path.join(tmpdir, 'custom-file')
+          t.on('end', function () { rimraf.sync(tmpdir) })
+          mkdirp.sync(tmpdir)
+          fs.writeFileSync(tmpfile, tmpfile)
+          value = tmpfile
+          break
+        case 'array':
+          value = ['custom-value']
+          break
+        case 'string':
+          value = 'custom-value'
+          break
+        default:
+          t.fail(`missing handling for config var type "${type}"`)
+      }
 
       process.env[envName] = value.toString()
 
       agent.start(agentOptsNoopTransport)
 
-      if (array) {
-        t.deepEqual(agent._conf[fixture[0]], [value])
-      } else {
-        t.strictEqual(agent._conf[fixture[0]], bool ? !fixture[2] : value)
+      switch (type) {
+        case 'bool':
+          t.strictEqual(agent._conf[fixture[0]], !fixture[2])
+          break
+        case 'array':
+          t.deepEqual(agent._conf[fixture[0]], value)
+          break
+        default:
+          t.strictEqual(agent._conf[fixture[0]], value)
       }
 
+      // Restore process.env state.
       if (existingValue) {
         process.env[envName] = existingValue
       } else {
@@ -149,37 +183,51 @@ optionFixtures.forEach(function (fixture) {
       var opts = {}
       var value1, value2
 
-      if (bool) {
-        value1 = !fixture[2]
-        value2 = fixture[2]
-      } else if (number) {
-        value1 = 2
-        value2 = 1
-      } else if (url) {
-        value1 = 'http://overwriting-value'
-        value2 = 'http://custom-value'
-      } else if (file) {
-        var tmpdir = path.join(os.tmpdir(), 'elastic-apm-node-test', String(Date.now()))
-        var tmpfile = path.join(tmpdir, 'custom-file')
-        t.on('end', function () { rimraf.sync(tmpdir) })
-        mkdirp.sync(tmpdir)
-        fs.writeFileSync(tmpfile, tmpfile)
-        value1 = path.join(tmpdir, 'does-not-exist')
-        value2 = tmpfile
-      } else {
-        value1 = 'overwriting-value'
-        value2 = 'custom-value'
+      switch (type) {
+        case 'bool':
+          value1 = !fixture[2]
+          value2 = fixture[2]
+          break
+        case 'number':
+          value1 = 2
+          value2 = 1
+          break
+        case 'url':
+          value1 = 'http://overwriting-value'
+          value2 = 'http://custom-value'
+          break
+        case 'file':
+          var tmpdir = path.join(os.tmpdir(), 'elastic-apm-node-test', String(Date.now()))
+          var tmpfile = path.join(tmpdir, 'custom-file')
+          t.on('end', function () { rimraf.sync(tmpdir) })
+          mkdirp.sync(tmpdir)
+          fs.writeFileSync(tmpfile, tmpfile)
+          value1 = path.join(tmpdir, 'does-not-exist')
+          value2 = tmpfile
+          break
+        case 'array':
+          value1 = ['overwriting-value']
+          value2 = ['custom-value']
+          break
+        case 'string':
+          value1 = 'overwriting-value'
+          value2 = 'custom-value'
+          break
+        default:
+          t.fail(`missing handling for config var type "${type}"`)
       }
 
       opts[fixture[0]] = value1
       process.env[envName] = value2.toString()
 
       agent.start(Object.assign({}, agentOptsNoopTransport, opts))
 
-      if (array) {
-        t.deepEqual(agent._conf[fixture[0]], [value2])
-      } else {
-        t.strictEqual(agent._conf[fixture[0]], value2)
+      switch (type) {
+        case 'array':
+          t.deepEqual(agent._conf[fixture[0]], value2)
+          break
+        default:
+          t.strictEqual(agent._conf[fixture[0]], value2)
       }
 
       if (existingValue) {
@@ -203,10 +251,13 @@ optionFixtures.forEach(function (fixture) {
     }
 
     var agent = new Agent().start(opts)
-    if (array) {
-      t.deepEqual(agent._conf[fixture[0]], fixture[2])
-    } else {
-      t.strictEqual(agent._conf[fixture[0]], fixture[2])
+
+    switch (type) {
+      case 'array':
+        t.deepEqual(agent._conf[fixture[0]], fixture[2])
+        break
+      default:
+        t.strictEqual(agent._conf[fixture[0]], fixture[2])
     }
 
     if (existingValue) {