Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sns instrumentation #2157

Merged
merged 23 commits into from
Aug 26, 2021
Merged

feat: sns instrumentation #2157

merged 23 commits into from
Aug 26, 2021

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Jul 13, 2021 •
edited
Loading

Closes #1955

This PR implements the AWS SNS spec for the AWS v2 SDK. Per the spec, it only instruments the publish API, and takes these proposed changes into account.

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jul 13, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Jul 13, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-26T00:22:31.267+0000

  • Duration: 19 min 51 sec

  • Commit: f16314b

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

Trends 🧪

Image of Build Times

Image of Tests

@astorm astorm requested a review from trentm July 13, 2021 22:34
@astorm astorm requested review from trentm and removed request for trentm July 20, 2021 05:04
trentm
trentm requested changes Jul 20, 2021
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
lib/instrumentation/modules/aws-sdk/sns.js Outdated Show resolved Hide resolved
lib/instrumentation/modules/aws-sdk/sns.js Outdated Show resolved Hide resolved
lib/instrumentation/modules/aws-sdk/sns.js Outdated Show resolved Hide resolved
lib/instrumentation/modules/aws-sdk/sns.js Outdated Show resolved Hide resolved
lib/instrumentation/modules/aws-sdk/sns.js Show resolved Hide resolved
@astorm
Copy link
Contributor Author

astorm commented Aug 25, 2021

Updated to match spec changes -- specifically

  • name now include to
  • action is now publish
  • "accesspoints" no longer special cased
  • New rules for TopicArn and TargetArn applied and tests adjusted to reflect this

Marking ready for review -- current failures appear unrelated.

@astorm astorm requested a review from trentm August 25, 2021 19:12
trentm
trentm previously approved these changes Aug 25, 2021
View reviewed changes
lib/instrumentation/modules/aws-sdk/sns.js Outdated Show resolved Hide resolved
lib/instrumentation/modules/aws-sdk/sns.js Outdated Show resolved Hide resolved
lib/instrumentation/modules/aws-sdk/sns.js Outdated Show resolved Hide resolved
@astorm astorm requested a review from trentm August 26, 2021 01:38
@astorm astorm merged commit 757e286 into master Aug 26, 2021
@astorm astorm deleted the astorm/sns branch August 26, 2021 15:59
dgieselaar pushed a commit to dgieselaar/apm-agent-nodejs that referenced this pull request Sep 10, 2021
@astorm @trentm @dgieselaar
feat: sns instrumentation (elastic#2157)
9826911 
* Implements implementation of Amazon SNS for the v2 APIs

elastic#1955

Co-authored-by: Trent Mick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 408] Instrumentation for AWS SNS
3 participants
@astorm @apmmachine @trentm