Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis run-context handling, error capture, span.outcome #2457

Merged
merged 6 commits into from
Nov 19, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Nov 18, 2021

Refs: #2430

Checklist

  • Implement code
  • Add tests
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@trentm trentm self-assigned this Nov 18, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 18, 2021
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-18T19:50:23.513+0000

  • Duration: 22 min 8 sec

  • Commit: c2a909a

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm requested a review from astorm November 18, 2021 20:27
console.log('SET key2: %s', err ? `${err.name}: ${err.message}` : reply)
t2.end()
clientSimErr.quit()
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEW NOTE: Running this now results in a trace like:

    transaction 4a51a6 "t1"
    `- span 90d434 "SET"
    `- span 71eb7c "GET"
    transaction 30c008 "t2"
    `- span e00acd "SET"
    `- error 0141bc "SET can't be processed. The connection is not yet established and the offline queue is deactivated."

Before this change it would be:

    transaction 4a51a6 "t1"
    `- span 90d434 "SET"
      `- span 71eb7c "GET"
    transaction 30c008 "t2"
    `- span e00acd "SET"

Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trentm trentm merged commit 3b0b9d1 into master Nov 19, 2021
@trentm trentm deleted the trentm/run-context-bleed-issue2430 branch November 19, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants