-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: redis run-context handling, error capture, span.outcome #2457
Conversation
…code after redis call is not)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
console.log('SET key2: %s', err ? `${err.name}: ${err.message}` : reply) | ||
t2.end() | ||
clientSimErr.quit() | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REVIEW NOTE: Running this now results in a trace like:
transaction 4a51a6 "t1"
`- span 90d434 "SET"
`- span 71eb7c "GET"
transaction 30c008 "t2"
`- span e00acd "SET"
`- error 0141bc "SET can't be processed. The connection is not yet established and the offline queue is deactivated."
Before this change it would be:
transaction 4a51a6 "t1"
`- span 90d434 "SET"
`- span 71eb7c "GET"
transaction 30c008 "t2"
`- span e00acd "SET"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Refs: #2430
Checklist