Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure correct run context for 'ws' instrumentation #2481

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Nov 30, 2021

Refs: #2430

Checklist

  • Implement code
  • Add tests
  • Add CHANGELOG.asciidoc entry

@trentm trentm self-assigned this Nov 30, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 30, 2021
@trentm
Copy link
Member Author

trentm commented Nov 30, 2021

Here is a passing TAV=ws test run (locally, node v12.22.6):

% TAV=ws ./node_modules/.bin/tav --compat
Testing compatibility with ws:
✔ 7.5.6
✔ 7.5.5
✔ 7.5.4
✔ 7.5.3
✔ 7.5.2
✔ 7.5.1
✔ 7.5.0
✔ 7.4.6
✔ 7.4.5
✔ 7.4.4
✔ 7.4.3
✔ 7.4.2
✔ 7.4.1
✔ 7.4.0
✔ 7.3.1
✔ 7.3.0
✔ 7.2.5
✔ 7.2.3
✔ 7.2.2
✔ 7.2.1
✔ 7.2.0
✔ 7.1.2
✔ 7.1.1
✔ 7.1.0
✔ 7.0.1
✔ 7.0.0

✔ 5.2.3
✔ 6.2.2
✔ 6.2.1
✔ 6.2.0
✔ 6.1.4
✔ 6.1.3
✔ 6.1.2
✔ 6.1.1
✔ 6.1.0
✔ 6.0.0
✔ 5.2.2
✔ 5.2.1
✔ 5.2.0
✔ 5.1.1
✔ 5.1.0
✔ 5.0.0
✔ 4.1.0
✔ 4.0.0
✔ 3.3.3
✔ 3.3.2
✔ 3.3.1
✔ 1.1.5
✔ 3.3.0
✔ 3.2.0
✔ 3.1.0
✔ 3.0.0
✔ 2.3.1
✔ 2.3.0
✔ 2.2.3
✔ 2.2.2
✔ 2.2.1
✔ 1.1.4
✔ 1.1.3
✔ 2.2.0
✔ 2.1.0
✔ 1.1.2
✔ 2.0.3
✔ 2.0.2
✔ 2.0.1
✔ 2.0.0
✔ 1.1.1
✔ 1.1.0
✔ 1.0.1
✔ 1.0.0

@apmmachine
Copy link
Contributor

apmmachine commented Nov 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-01T21:39:31.026+0000

  • Duration: 20 min 57 sec

  • Commit: cc7d208

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm marked this pull request as ready for review November 30, 2021 21:11
@trentm trentm requested a review from astorm November 30, 2021 21:11
astorm
astorm previously approved these changes Dec 2, 2021
Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 adds the new run context handling while leaving older functionality in place.

@trentm trentm merged commit 67a04c2 into master Dec 2, 2021
@trentm trentm deleted the trentm/run-context-ws branch December 2, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants