Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run context handling for aws-sdk DynamoDB instrumentation #2504

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Dec 7, 2021

This also adds a couple aws-sdk-related tests to the TAV=aws-sdk tests.

Refs: #2430

Checklist

  • Implement code
  • Add tests
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Dec 7, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Dec 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-07T23:33:04.394+0000

  • Duration: 20 min 9 sec

  • Commit: 97d317b

Test stats 🧪

Test Results
Failed 0
Passed 235018
Skipped 0
Total 235018

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Dec 7, 2021

@elasticmachine run elasticsearch-ci/docs skiplinkcheck

@trentm trentm requested a review from astorm December 8, 2021 00:56
@trentm trentm self-assigned this Dec 8, 2021
Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 approved -- looks like a pretty now-standard context swap.

@@ -1,3 +1,5 @@
'use strict'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 here -- it'd be nice if our linter/CI caught these though (not for this PR, just something to keep in mind for the future)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, agreed. I think we can further configure our standard usage with eslint rules? https://eslint.org/docs/rules/strict

@@ -479,6 +479,8 @@ aws-sdk:
# Test v2.858.0, every N=31 of 159 releases, and current latest.
versions: '2.858.0 || 2.889.0 || 2.920.0 || 2.951.0 || 2.982.0 || 2.1013.0 || 2.1016.0 || >2.1016.0 <3'
commands:
- node test/instrumentation/modules/aws-sdk/aws4-retries.test.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for getting these tests into the tav runner while we're in here.

@trentm trentm merged commit 4881c0c into master Dec 9, 2021
@trentm trentm deleted the trentm/run-context-dynamodb branch December 9, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants