-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run context handling for aws-sdk DynamoDB instrumentation #2504
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@elasticmachine run elasticsearch-ci/docs skiplinkcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 approved -- looks like a pretty now-standard context swap.
@@ -1,3 +1,5 @@ | |||
'use strict' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 here -- it'd be nice if our linter/CI caught these though (not for this PR, just something to keep in mind for the future)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah, agreed. I think we can further configure our standard
usage with eslint rules? https://eslint.org/docs/rules/strict
@@ -479,6 +479,8 @@ aws-sdk: | |||
# Test v2.858.0, every N=31 of 159 releases, and current latest. | |||
versions: '2.858.0 || 2.889.0 || 2.920.0 || 2.951.0 || 2.982.0 || 2.1013.0 || 2.1016.0 || >2.1016.0 <3' | |||
commands: | |||
- node test/instrumentation/modules/aws-sdk/aws4-retries.test.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for getting these tests into the tav runner while we're in here.
This also adds a couple aws-sdk-related tests to the TAV=aws-sdk tests.
Refs: #2430
Checklist