Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure correct run context for 'elasticsearch' (legacy) instrumentation #2551

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 28, 2022

Refs: #2430

Checklist

  • Implement code
  • Add tests
  • Add CHANGELOG.asciidoc entry

@trentm trentm self-assigned this Jan 28, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 28, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jan 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-28T18:56:57.132+0000

  • Duration: 25 min 6 sec

  • Commit: 38f39c1

Test stats 🧪

Test Results
Failed 0
Passed 243775
Skipped 0
Total 243775

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Jan 28, 2022

run module tests for elasticsearch

@trentm trentm marked this pull request as ready for review January 28, 2022 17:37
@trentm trentm requested a review from astorm January 28, 2022 17:37
@trentm trentm merged commit 00fe15d into main Jan 31, 2022
@trentm trentm deleted the trentm/run-context-es-legacy branch January 31, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants