Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make TraceParent a local class module #2669

Merged
merged 4 commits into from
May 3, 2022
Merged

Conversation

astorm
Copy link
Contributor

@astorm astorm commented May 2, 2022

This PR pulls the global NPM traceparent module into a local class module file.

The span statistics work (described here) will require us to modify the TraceParent class (by giving it the ability to change the recorded/sampled flag). This seems like a good opportunity to pull the TraceParent class into the main repo and soft-deprecate the stand alone traceparent NPM module.

Checklist

  • Implement code
  • Add tests
  • [ ] Update TypeScript typings
  • [ ] Update documentation
  • Add CHANGELOG.asciidoc entry

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 2, 2022
@apmmachine
Copy link
Contributor

apmmachine commented May 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-03T20:02:39.194+0000

  • Duration: 20 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 249219
Skipped 0
Total 249219

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@astorm astorm marked this pull request as ready for review May 3, 2022 04:16
@astorm astorm requested review from trentm and felixbarny May 3, 2022 04:17
@astorm astorm merged commit f6c4ee8 into main May 3, 2022
@astorm astorm deleted the astorm/pull-in-traceparent branch May 3, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants