Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setRecorded for traceparent/tracecontext #2687

Merged
merged 5 commits into from
May 12, 2022

Conversation

astorm
Copy link
Contributor

@astorm astorm commented May 11, 2022

Part 1 of 3 for #2302

Implements a setRecorded method for the TraceParent (and TraceContext) classes, bringing the Node.js agent more into alignment with the Java Agent's TraceContext implementation and provides a way to set this value for spans or transactions at times other than object construction.

Checklist

  • Implement code
  • Add tests
    - [ ] Update TypeScript typings
    - [ ] Update documentation
    - [x] Add CHANGELOG.asciidoc entry

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 11, 2022
@apmmachine
Copy link
Contributor

apmmachine commented May 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T15:55:53.979+0000

  • Duration: 21 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 255793
Skipped 0
Total 255793

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@astorm astorm marked this pull request as ready for review May 11, 2022 23:28
@astorm astorm requested a review from trentm May 11, 2022 23:28
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@astorm astorm merged commit 8b6c11a into main May 12, 2022
@astorm astorm deleted the astorm/span-stats-traceparent-recorded branch May 12, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants