Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add empty file so the updatecli does not fail #3587

Merged
merged 1 commit into from
Aug 24, 2023
Merged

chore: add empty file so the updatecli does not fail #3587

merged 1 commit into from
Aug 24, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 24, 2023

updatecli automation failed since the file didn't exist

See https://github.com/elastic/apm-agent-nodejs/actions/runs/5960084267/job/16166816284#step:3:1616

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@v1v v1v requested a review from a team August 24, 2023 06:11
@v1v v1v self-assigned this Aug 24, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 24, 2023
@david-luna
Copy link
Member

@v1v I did not know the destination file must exist to do the copy so I did not created it in #3585. My apologies

@v1v
Copy link
Member Author

v1v commented Aug 24, 2023

@v1v I did not know the destination file must exist to do the copy so I did not created it in #3585. My apologies

No worries, by default we don't use the flag to create the file if it does not exist. Just went through the different notifications and saw this failure :)

@v1v v1v merged commit ed43174 into elastic:main Aug 24, 2023
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
@v1v @fpm-peter
updatecli: create empty file (elastic#3587)
e3d3be1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-luna david-luna david-luna approved these changes

Assignees

@v1v v1v

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @david-luna