Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): change from ubuntu-latest to ubuntu-24.04 #4404

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 9, 2025

This is (a) to avoid the warnings in workflow runs, e.g.:

test-tav (@apollo/server 22) ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

and (b) to try it out ahead of the switch.

This is (a) to avoid the warnings in workflow runs, e.g.:

    test-tav (@apollo/server 22) ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636

and (b) to try it out ahead of the switch.
@trentm trentm requested review from david-luna, v1v and reakaleek January 9, 2025 16:48
@trentm trentm self-assigned this Jan 9, 2025
Copy link
Member Author

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav

@trentm
Copy link
Member Author

trentm commented Jan 9, 2025

The 100+ repeated warnings makes finding other warnings difficult:

Screenshot 2025-01-09 at 8 49 34 AM

@v1v
Copy link
Member

v1v commented Jan 9, 2025

IIUC, that's a temporary warning while the transition is ongoing.

We have been discussing what we plan here, either pinning the version or using the latest.

Somehow, we, robots, agreed to keep using the latest if possible to reduce the burden of bumping the runner version in dozens of GH repositories. However, you can choose the best strategy that works for your case :)

@v1v
Copy link
Member

v1v commented Jan 9, 2025

and (b) to try it out ahead of the switch.

I think the ubuntu-24 is already there - those out of the box annotations are certainly misleading IMO.

See a random build -> https://github.com/elastic/apm-agent-nodejs/actions/runs/12694649420/job/35386607654

  Image: ubuntu-24.04
  Version: 20250105.1.0

@trentm trentm merged commit 6e047fe into main Jan 9, 2025
145 of 199 checks passed
@trentm trentm deleted the trentm/ci-ubuntu-24.04 branch January 9, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants