Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8.4 compatibility #1255

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

julien-maurel
Copy link

@julien-maurel julien-maurel commented Dec 30, 2024

Hi
I'm not sure everything is ok, i did it for my needed so I just know that .deb file works
But if these changes can help...

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
ae53f5d

Please, read and sign the above mentioned agreement if you want to contribute to this project

@intuibase intuibase self-requested a review January 9, 2025 15:37
@intuibase
Copy link
Contributor

Hey @julien-maurel
Thank you for your contribution.
I've updated yours branch a bit to pass static and phpt tests. I hope you don’t mind that I pushed some changes to your repository.

@julien-maurel
Copy link
Author

Hey @julien-maurel Thank you for your contribution. I've updated yours branch a bit to pass static and phpt tests. I hope you don’t mind that I pushed some changes to your repository.

You're welcome, I would have liked to finish it, but difficult to take time to check how CI and other formats work.
No worries, commit as you like, I fork it just do do the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants