Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 555] Add automated span type/subtype checking against shared spec #1305

Closed
basepi opened this issue Aug 24, 2021 · 0 comments · Fixed by #1647
Closed

[META 555] Add automated span type/subtype checking against shared spec #1305

basepi opened this issue Aug 24, 2021 · 0 comments · Fixed by #1647
Labels
agent-python automation chore stretch

Comments

@basepi
Copy link
Contributor

basepi commented Aug 24, 2021

Spec PR: elastic/apm#443

To start, we would just ensure that all span types/subtypes appear in the spec. In the future we will work on cross-agent alignment.
@SylvainJuge SylvainJuge mentioned this issue Sep 8, 2021
Open
8 tasks
@AlexanderWert AlexanderWert changed the title Add automated span type/subtype checking against shared spec [META 555] Add automated span type/subtype checking against shared spec Nov 18, 2021
@AlexanderWert AlexanderWert mentioned this issue Nov 18, 2021
Open
7 tasks
@estolfo estolfo added this to the 8.2 milestone Jan 19, 2022
@estolfo estolfo modified the milestones: 8.2, 8.3 Mar 23, 2022
@estolfo estolfo removed this from the 8.3 milestone May 23, 2022
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Sep 27, 2022
@beniwohli
validate JSON types/subtypes
20d930b 
as our default is `code.custom`, which is not yet part of the spec,
we get a lot of warnings with this.

Closes elastic#1305
@beniwohli beniwohli mentioned this issue Sep 27, 2022
Merged
beniwohli added a commit that referenced this issue Oct 13, 2022
@beniwohli
validate JSON types/subtypes (#1647)
6097d44 
as our default is `code.custom`, which is not yet part of the spec,
we get a lot of warnings with this.

Closes #1305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-python automation chore stretch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate JSON types/subtypes beniwohli/apm-agent-python
4 participants
@estolfo @basepi @SylvainJuge @AlexanderWert