-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment of span type/subtype #502
Comments
@elastic/apm-agent-ruby there could be a few quick wins here:
For |
Completely agree, @SylvainJuge. Good ideas 👍 |
Proposal for internal delegation spans, simply call them |
Adding |
This is a meta-issue to describe all the known alignment issues/inconsistencies with span type / subtype
The current state of specification is stored in tests/agents/json-specs/span_types.json in JSON format.
For convenience, we will refer to span type & subtype as
type/subtype
.This issue description will be modified when alignment progresses.
List of things that need improvement/simplification/alignment
app
for internal delegation that is not framework/library specific: we currently haveapp/mailer
,app/controller
,app/resource
andapp/graphql
span type/subtype: alignment step 1 #513external/email
for spans that send emails (would replaceapp/mailer
)json/parse
andjson/generate
as it's only used by ruby, span naming might be enough. deprecated in span type/subtype: alignment step 1 #513template/*
, thus any value will be accepted as subtype, listing all known values for each platform is required to replace this with an exhaustive list, or we could replace it with a generic subtype.websocket
toexternal/websocket
db/sqllite
withdb/sqlite3
deprecated in span type/subtype: alignment step 1 #513db/sqlserver
anddb/mssql
deprecated in span type/subtype: alignment step 1 #513Process
The text was updated successfully, but these errors were encountered: