Dropped span statistics #1327
Dropped span statistics #1327
Conversation
this allows us to use these values for dropped-span metrics without having to store them on DroppedSpan, as they are available on the capture_span object.
for dropped-span metrics, we need to collect these values for DroppedSpan as well, so we might as well remove the duplication
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Looks great! One nit.
Definitely not going to play well with my lambda changes to allow for easier backdating of spans/transactions but life will go on. Maybe I'll drop the backdating stuff since we're not actually doing that in lambda right anymore, at least for now.
Co-authored-by: Colton Myers <[email protected]>
|
@basepi just for my understanding, how would this PR make backdating of spans more difficult in Lambda? |
|
Oh, it won't make it more difficult, it will just merge conflict and I'll have to move some stuff around. I'm torn on whether I should even include backdating since we're not actually using it anymore. Some day it may be useful but I don't know? |
…opped-span-statistics
Related issues
closes #1310