Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META 621] Improve Granularity for SQL Databases #1244

Open
3 of 4 tasks
AlexanderWert opened this issue Mar 24, 2022 · 0 comments
Open
3 of 4 tasks

[META 621] Improve Granularity for SQL Databases #1244

AlexanderWert opened this issue Mar 24, 2022 · 0 comments

Comments

@AlexanderWert
Copy link
Member

AlexanderWert commented Mar 24, 2022

issue details

issue details

There are two parts to improving the granularity for SQL Databases:

  • adding new fields to agent-server protocol, for now it's mostly to future-proof the captured data as we have to keep existing fields for compatibility with UI.
  • capture values for those new fields on SQL Databases, which is actually providing better granularity to the end-user.

Each step can be completed independently, but this task will be considered complete when both parts are completed.

First step : add new service fields

  • Add and capture values for span.context.service.target.type and span.context.service.target.name for exit spans.
  • Infer from those new fields the value of span.destination.service.resource and keep sending it.
  • Add service_target_* fields to dropped spans metrics: add service_target_type and service_target_name next to destination_service_resource in transaction.dropped_spans_stats array, the related metrics documents should include span.service.target.type and span.service.target.name fields.
  • Handle span compression with new fields (stop relying on resource internally)

Second step : capture values for new fields

Note: a prerequisite for the second part regarding dropped span stats is this issue: #1150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants