-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Granularity for SQL Databases #621
Comments
@AlexanderWert What if the agent doesn't detect the apm server version, how can it know which field to send? |
I think agents should default to sending all three fields and if they detect that the APM Server they're connected to is new, they MAY drop the old field. But it's also totally fine to always send all fields, IMO. |
Thanks, @felixbarny. @AlexanderWert if you agree, I'll update the description to reflect Felix's input. |
Ideally, I think the description and this discussion should happen on the spec PR. Otherwise, it may get out-of-sync. |
There are two parts to improving the granularity for SQL Databases:
Each step can be completed independently, but this task will be considered complete when both parts are completed.
First step : add new service fields
span.context.service.target.type
andspan.context.service.target.name
for exit spans.span.destination.service.resource
and keep sending it.service_target_*
fields to dropped spans metrics: addservice_target_type
andservice_target_name
next todestination_service_resource
intransaction.dropped_spans_stats
array, the related metrics documents should includespan.service.target.type
andspan.service.target.name
fields.resource
internally)Second step : capture values for new fields
Spec issue
Agent issues
The text was updated successfully, but these errors were encountered: