-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate span.type and .subtype against shared spec #1030
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor questions/comments on my end for the shared JSON spec.
I start to feel that we could add another descriptive field to indicate which agent is using what, that will later help to align and find which ones are mostly used, and which ones are the exceptions & oddities, what do you think ?
I think marking agent langs in the spec is a good idea so long as we are in the process of aligning 👍 |
I've just updated the original PR (elastic/apm#443) with |
There are only a few differences with the elastic/apm#443 PR, thus you can directly update it once this is merged without doing a PR on PR :-). |
Closes #1018
Found out that we still sent types in the legacy joined formTurns out this is still Good Behaviour™type.subtype.action
.