Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span compression #1180

Closed
wants to merge 5 commits into from
Closed

Add span compression #1180

wants to merge 5 commits into from

Conversation

mikker
Copy link
Contributor

@mikker mikker commented Nov 1, 2021

See #1021

Currently passing all tests but one, which is concerning this part from the spec:

    if (!child.isCompressionEligible()) {
        if (buffered != null) {
            report(buffered) # <-- reporting buffered from sibling
            buffered = null  # <-- resetting buffer
        }
        report(child)
        return
    }

Keeping track of children and buffers and such is very difficult and the fact that we use the instrumenter to report instead of letting the spans themselves do it doesn't make it easier.

@apmmachine
Copy link
Contributor

apmmachine commented Nov 1, 2021

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2022-02-03T05:45:23.157+0000

  • Duration: 7 min 6 sec

  • Commit: 795fe77

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mikker
Copy link
Contributor Author

mikker commented Mar 8, 2022

Hey friends! Closing this one because cleaning my GH up a bit. Will leave the branch – but maybe copy it somewhere if you want to make sure to not lose the work. Hope you're all well ❤️

@mikker mikker closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants