Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to match spec, change <PHONE_NUMBER> to [PHONENUMBER] #1246

Merged
merged 2 commits into from
May 16, 2022
Merged

Update to match spec, change <PHONE_NUMBER> to [PHONENUMBER] #1246

merged 2 commits into from
May 16, 2022

Conversation

jaggederest
Copy link
Contributor

@jaggederest jaggederest commented Apr 4, 2022 •
edited
Loading

What does this pull request do?

Updates SNS spy to use a standard placeholder in lieu of actual phone numbers - previously <PHONE_NUMBER>, now updated to [PHONENUMBER] per spec at https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-aws.md

Why is it important?

Current implementation does not match the specified behavior

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

Relates elastic/apm#478

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 4, 2022 •
edited
Loading

💚 CLA has been signed

@apmmachine
Copy link
Contributor

apmmachine commented Apr 4, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-16T12:56:10.950+0000

  • Duration: 33 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 44189
Skipped 80
Total 44269

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@astorm
Copy link

astorm commented Apr 4, 2022

jenkins run the tests please

@jaggederest jaggederest requested a review from estolfo April 13, 2022 06:37
estolfo
estolfo approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
And just a reminder to update the CHANGELOG.

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 99.2% (124/125) ❕
Classes 99.2% (124/125) ❕
Lines 59.666% (2500/4190) ❕
Conditionals 100.0% (0/0) 💚

@jaggederest jaggederest merged commit a784c58 into elastic:main May 16, 2022
@jaggederest jaggederest deleted the sns-updates branch May 16, 2022 22:12
estolfo pushed a commit that referenced this pull request Mar 2, 2023
@jaggederest @estolfo
Update to match spec, change <PHONE_NUMBER> to [PHONENUMBER] (#1246)
d9ba7f2 
* Update to match spec, change <PHONE_NUMBER> to [PHONENUMBER]

* Update changelog to reflect 1246 changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estolfo estolfo estolfo approved these changes

Assignees
No one assigned
Labels
agent-ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaggederest @apmmachine @astorm @estolfo