Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: dynamic specs #1439

Merged
merged 3 commits into from
Jan 25, 2024
Merged

updatecli: dynamic specs #1439

merged 3 commits into from
Jan 25, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 25, 2024

What does this PR do?

Test

CI

See https://github.com/elastic/apm-agent-ruby/actions/runs/7652598237 that created https://github.com/elastic/apm-agent-ruby/pull/1438/files

Locally:

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="[email protected]" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --debug

or without pushing any changes

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="[email protected]" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --push=false --debug

additionally, you can change the org from elastic to your own GitHub avatar.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@v1v v1v requested review from a team January 25, 2024 09:41
@v1v v1v self-assigned this Jan 25, 2024
@v1v v1v enabled auto-merge (squash) January 25, 2024 10:59
@v1v v1v merged commit 4d45d7f into main Jan 25, 2024
@v1v v1v deleted the feature/updatecli-dynamic branch January 25, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants