Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make field max length configurable #432

Closed
wants to merge 2 commits into from

feat: regenerate model to conditionally enable maxLength check

766fc0b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

feat: make field max length configurable #432

feat: regenerate model to conditionally enable maxLength check
766fc0b
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded Jan 24, 2025 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: 766fc0b

Base sha: 99f84c0

Degraded: false

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 25058 1% 26234.6 1% +4.70% (p=0.008 n=5+5)
Encode/format=json-2 13277.6 4% 13676 1% ~ (p=0.151 n=5+5)
Encode/format=vtproto 4781.4 2% 4622.8 2% -3.32% (p=0.008 n=5+5)
Encode/format=vtproto-2 2578.8 1% 2779 14% ~ (p=0.151 n=5+5)
Decode/format=vtproto 18804.6 2% 18796.5 0% ~ (p=0.905 n=5+4)
Decode/format=vtproto-2 10844.6 3% 11156.8 4% ~ (p=0.095 n=5+5)
Decode/format=json 128841 8% 125969 2% ~ (p=1.000 n=5+5)
Decode/format=json-2 67244.8 7% 67062 3% ~ (p=0.841 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7592 0% 7592 0% ~ (all equal)
Encode/format=json-2 7593 0% 7593 0% ~ (all equal)
Encode/format=vtproto 3072 0% 3072 0% ~ (all equal)
Encode/format=vtproto-2 3072 0% 3072 0% ~ (all equal)
Decode/format=vtproto 12952 0% 12952 0% ~ (all equal)
Decode/format=vtproto-2 12952 0% 12952 0% ~ (all equal)
Decode/format=json 14281.4 0% 14282.8 0% ~ (p=0.103 n=5+5)
Decode/format=json-2 14283 0% 14281.6 0% ~ (p=0.079 n=5+5)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 26 0% 26 0% ~ (all equal)
Encode/format=json-2 26 0% 26 0% ~ (all equal)
Encode/format=vtproto 1 0% 1 0% ~ (all equal)
Encode/format=vtproto-2 1 0% 1 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)
Decode/format=json 379 0% 379 0% ~ (all equal)
Decode/format=json-2 379 0% 379 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 284.18 1% 278.98 4% -1.83% (p=0.032 n=5+5)
NDStreamDecoder-2 157.14 12% 148 9% ~ (p=0.095 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 15990.4 12% 15437.6 9% ~ (p=0.095 n=5+5)
APMEventToJSON/to-json-2 13152.4 2% 13008.8 2% ~ (p=0.421 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2616 0% 2616 0% ~ (all equal)
APMEventToJSON/to-json-2 2616 0% 2616 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 38 0% 38 0% ~ (all equal)
APMEventToJSON/to-json-2 38 0% 38 0% ~ (all equal)
View more details on GitHub Actions