Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(dra): skip snapshots with qualifier and run in parallel #15274

Merged
merged 5 commits into from
Jan 17, 2025
Merged

ci(dra): skip snapshots with qualifier and run in parallel #15274

merged 5 commits into from
Jan 17, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 17, 2025 •
edited
Loading

Motivation/summary

#15217 honoured the qualifier but qualifier is not needed for snapshots.
Then, I replaced the single list BK matrix for a simpler data structure and ran the DRA faster in parallel for (staging and snapshots).

I somehow feel, the logic is easier in the shell script instead of the BK pipeline. Even though if it spins up one worker for staging in 8.x.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

The feature branches in the upstream get triggered automatically and run the DRA BK pipeline in dry-run mode.

See the below builds:

  • build for a non-qualifier/
  • build for the qualifer=alpha1.

Related issues

@v1v v1v added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 17, 2025
@v1v v1v self-assigned this Jan 17, 2025
@v1v v1v marked this pull request as ready for review January 17, 2025 09:36
@v1v v1v requested a review from a team as a code owner January 17, 2025 09:36
@v1v v1v requested a review from a team January 17, 2025 09:36
@v1v v1v changed the title dra: skip snapshots with qualifier and run in parallel ci(dra): skip snapshots with qualifier and run in parallel Jan 17, 2025
simitt
simitt previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nit, otherwise LGTM

.buildkite/scripts/dra.sh Outdated Show resolved Hide resolved
.buildkite/scripts/dra.sh Outdated Show resolved Hide resolved
@v1v v1v enabled auto-merge (squash) January 17, 2025 10:33
@v1v v1v requested a review from simitt January 17, 2025 10:49
@v1v v1v merged commit 57e3a42 into main Jan 17, 2025
12 checks passed
@v1v v1v deleted the feature/qualifier-no-version branch January 17, 2025 11:50
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@v1v @mergify
ci(dra): skip snapshots with qualifier and run in parallel (#15274)
2f95ea7 
(cherry picked from commit 57e3a42)
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
2 tasks
@v1v v1v mentioned this pull request Jan 17, 2025
Merged
2 tasks
mergify bot added a commit that referenced this pull request Jan 17, 2025
@mergify @v1v
ci(dra): skip snapshots with qualifier and run in parallel (#15274) (#…
ac4a931 
…15275)

(cherry picked from commit 57e3a42)

Co-authored-by: Victor Martinez <[email protected]>
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

Assignees

@v1v v1v

Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @simitt