-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform: support TBS in standalone_apm_server #15337
Conversation
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful!
Support TBS in testing/infra/terraform/modules/standalone_apm_server (cherry picked from commit f6af1e9)
Support TBS in testing/infra/terraform/modules/standalone_apm_server (cherry picked from commit f6af1e9) Co-authored-by: Carson Ip <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This is the root cause of 0 sampled traces in benchmarks, a bug introduced in #15337.
This is the root cause of 0 sampled traces in benchmarks, a bug introduced in #15337. (cherry picked from commit 67ec6fd) Co-authored-by: Carson Ip <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Motivation/summary
Support TBS in testing/infra/terraform/modules/standalone_apm_server
Checklist
For functional changes, consider:
How to test these changes
Run
testing/benchmark
with tfvarsOutput should contain a non-zero tbs_lsm_size e.g.
Related issues
Follow up to #14985
Meta issue #14931