Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: support TBS in standalone_apm_server #15337

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jan 22, 2025

Motivation/summary

Support TBS in testing/infra/terraform/modules/standalone_apm_server

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Run testing/benchmark with tfvars

apm_server_tail_sampling = true
apm_server_tail_sampling_storage_limit = "30GB"
run_standalone = true
standalone_apm_server_instance_size = "c6id.2xlarge"
worker_instance_type = "c6i.4xlarge"
standalone_apm_server_volume_type = "gp3"
standalone_apm_server_volume_size = 40

Output should contain a non-zero tbs_lsm_size e.g.

BenchmarkAgentAll-512        871         163274501 ns/op                 0 error_responses/sec        2205 errors/sec        19059 events/sec          995.0 gc_cycles        1049 max_goroutines        937528464 max_heap_alloc          4870724 max_heap_objects     1078747136 max_rss              22.21 mean_available_indexers            16854 metrics/sec           0 spans/sec      30967789 tbs_lsm_size  148710064 tbs_vlog_size                 0 txs/sec      436651105 B/op   4260866 allocs/op

Related issues

Follow up to #14985

Meta issue #14931

Copy link
Contributor

mergify bot commented Jan 22, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 22, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 22, 2025
@carsonip carsonip mentioned this pull request Jan 22, 2025
12 tasks
@carsonip carsonip requested a review from kruskall January 22, 2025 16:54
@carsonip carsonip marked this pull request as ready for review January 22, 2025 22:43
@carsonip carsonip requested a review from a team as a code owner January 22, 2025 22:43
@carsonip carsonip enabled auto-merge (squash) January 22, 2025 23:56
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful!

@carsonip carsonip merged commit f6af1e9 into elastic:main Jan 23, 2025
17 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2025
Support TBS in testing/infra/terraform/modules/standalone_apm_server

(cherry picked from commit f6af1e9)
mergify bot added a commit that referenced this pull request Jan 23, 2025
Support TBS in testing/infra/terraform/modules/standalone_apm_server

(cherry picked from commit f6af1e9)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
carsonip added a commit that referenced this pull request Jan 27, 2025
This is the root cause of 0 sampled traces in benchmarks, a bug introduced in #15337.
mergify bot pushed a commit that referenced this pull request Jan 27, 2025
This is the root cause of 0 sampled traces in benchmarks, a bug introduced in #15337.

(cherry picked from commit 67ec6fd)
mergify bot added a commit that referenced this pull request Jan 27, 2025
This is the root cause of 0 sampled traces in benchmarks, a bug introduced in #15337.

(cherry picked from commit 67ec6fd)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants