functionaltests: handle terraform output errors #15355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @endorama? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
kruskall
previously approved these changes
Jan 23, 2025
marclop
reviewed
Jan 24, 2025
functionaltests/8_15_test.go
Outdated
Comment on lines
63
to
64
| err = tf.Output("apm_url", &escfg.APMServerURL) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Minor nit to reduce the number of lines, I think it's still quite readable:
Suggested change
| err = tf.Output("apm_url", &escfg.APMServerURL) | |
| require.NoError(t, err) | |
| require.NoError(t, tf.Output("apm_url", &escfg.APMServerURL)) |
kruskall
approved these changes
Jan 24, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
* handle terraform output errors * shorten checks (cherry picked from commit 8c523e6)
mergify bot
added a commit
that referenced
this pull request
Jan 24, 2025
* handle terraform output errors * shorten checks (cherry picked from commit 8c523e6) Co-authored-by: Edoardo Tenani <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Code in functionaltests relying on
terraform.Runner.Output()was not checking errors. If for any reason the outputvalue is wrong and the function returns an error this was ignored and the test would proceed, failing at a later
stage with ambiguous errors.
Add a clarifying error if the requested output name is not available from the Terraform outputs.
Checklist
How to test these changes
Run the functionaltests. I tested it locally.
Related issues