Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF: restore explicit tags for apm_standalone module #15357

Merged

Conversation

1pkg
Copy link
Member

@1pkg 1pkg commented Jan 23, 2025

Motivation/summary

This PR reverts changes made in #15078 which are causing the issues for smoke-tests pipeline https://github.com/elastic/apm-server/actions/runs/12937104670/job/36084296766#step:9:50. Making the tags be explicitly propagated in both benchmarks and smoke-tests pipelines again.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@1pkg 1pkg requested a review from a team as a code owner January 23, 2025 22:32
@1pkg 1pkg self-assigned this Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

This pull request does not have a backport label. Could you fix it @1pkg? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 23, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 23, 2025
@1pkg 1pkg enabled auto-merge (squash) January 23, 2025 22:34
@1pkg 1pkg merged commit 3ed1167 into elastic:main Jan 23, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2025
@1pkg 1pkg deleted the restore_explicit_tags_for_apm_standalone_tf_module branch January 23, 2025 22:54
mergify bot added a commit that referenced this pull request Jan 23, 2025
(cherry picked from commit 3ed1167)

Co-authored-by: Kostiantyn Masliuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants