Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop backward compatible flag #15425

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

kruskall
Copy link
Member

Motivation/summary

beats removed backward compatible flag support in elastic/beats#42117 but we're adding it back at https://github.com/elastic/apm-server/blob/main/internal/beatcmd/init.go#L57-L61We should remove the hack as well

Closes #15424

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@kruskall kruskall requested a review from a team as a code owner January 28, 2025 11:10
Copy link
Contributor

mergify bot commented Jan 28, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 28, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 28, 2025
@kruskall kruskall added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Jan 28, 2025
@@ -52,11 +52,5 @@ func initRand() {
}

func initFlags() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there is no more point to have dedicated initFlags function just move cfgfile.Initialize() directly to init

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will cleanup in a followup PR

@kruskall kruskall enabled auto-merge (squash) January 28, 2025 22:54
@kruskall kruskall merged commit 42e0cbf into elastic:main Jan 28, 2025
12 checks passed
@kruskall kruskall deleted the feat/drop-backward-flag branch January 28, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove backward compatible flag support
2 participants