Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt testing/benchmark to okta-aws-cli #15512

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jan 31, 2025

Motivation/summary

Use okta-aws-cli with elastic-observability

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

make auth apply to create infra. make destroy or make auth destroy (if credentials expired) to destroy infra.
~/.aws/credentials should be updated.

Related issues

Fixes #15511

@carsonip carsonip requested a review from a team as a code owner January 31, 2025 18:47
@carsonip carsonip marked this pull request as draft January 31, 2025 18:47
Copy link
Contributor

mergify bot commented Jan 31, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@carsonip carsonip marked this pull request as ready for review January 31, 2025 22:26
1pkg
1pkg previously approved these changes Feb 1, 2025
Copy link
Member

@1pkg 1pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@carsonip carsonip marked this pull request as draft February 1, 2025 13:36
@carsonip carsonip marked this pull request as ready for review February 1, 2025 13:44
@carsonip carsonip requested a review from 1pkg February 1, 2025 13:48
@mkdir -p ~/.aws
@touch $@
auth:
@okta-aws-cli --profile $(AWS_PROFILE) --write-aws-credentials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the elastic-okta-awscli - the only CLI available for some Elastic employees. The current elastic-observability should work with that tool.

We can sync up and discuss this if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt testing/benchmark to use okta-aws-cli
3 participants