Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] TBS: change default disk usage threshold to 0.8 (backport #15524) #15525

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 3, 2025

Motivation/summary

Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

With this change, the log looks like

setting disk usage threshold to 80% of total disk space of 912.7gb

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Check logs setting disk usage threshold ... when storage_limit is set to 0.

Related issues

Changing the default set in #15467


This is an automatic backport of pull request #15524 done by [Mergify](https://mergify.com).

Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

(cherry picked from commit 9ccfae6)

# Conflicts:
#	changelogs/9.0.asciidoc
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 3, 2025
@mergify mergify bot requested a review from a team as a code owner February 3, 2025 14:56
Copy link
Contributor Author

mergify bot commented Feb 3, 2025

Cherry-pick of 9ccfae6 has failed:

On branch mergify/bp/9.0/pr-15524
Your branch is up to date with 'origin/9.0'.

You are currently cherry-picking commit 9ccfae64.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelogs/all-breaking-changes.asciidoc
	modified:   internal/beater/config/config_test.go
	modified:   internal/beater/config/sampling.go
	modified:   x-pack/apm-server/sampling/eventstorage/storage_manager.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   changelogs/9.0.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot merged commit fadcc78 into 9.0 Feb 3, 2025
17 checks passed
@mergify mergify bot deleted the mergify/bp/9.0/pr-15524 branch February 3, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant