Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] fix: do not overwrite registries when publishing otel metrics to beats (backport #15517) #15537

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 4, 2025

Motivation/summary

update apm-server registry mapping logic to avoid overwriting onkey handlers

discovered while backporting the otel changes. Already added in 8.x

if metrics have similar paths the onkey handler is overwritten. To avoid this process all the metrics path first to build a tree and produce them in order.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #15517 done by [Mergify](https://mergify.com).

#15517)

* fix: do not overwrite registries when publishing otel metrics to beats

update apm-server registry mapping logic to avoid overwriting
onkey handlers

* test: add unit test for apm-server mapping logic

(cherry picked from commit 9350ef5)
@mergify mergify bot requested a review from a team as a code owner February 4, 2025 08:52
@mergify mergify bot added the backport label Feb 4, 2025
@mergify mergify bot merged commit 07ed0e2 into 9.0 Feb 4, 2025
15 checks passed
@mergify mergify bot deleted the mergify/bp/9.0/pr-15517 branch February 4, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant