feat(fips): remove keystore subcommand and config handling #15545
+161
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the keystore is providing obfuscation of data on disk by using an empty password by default. This fails in fips only mode with the following error: crypto/hmac: use of keys shorter than 112 bits is not allowed in FIPS 140-only mode Disable the keystore subcommand and do not try to create one when loading the config.
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
kruskall
added
backport-8.x
1pkg
reviewed
Feb 4, 2025
| "github.com/elastic/elastic-agent-libs/keystore" | ||
| ) | ||
|
|
||
| func TestLoadConfigKeystore(t *testing.T) { |
There was a problem hiding this comment.
Will this test fail if build with requirefips?
1pkg
reviewed
Feb 4, 2025
| ) | ||
|
|
||
| // loadKeystore returns the appropriate keystore based on the configuration. | ||
| func loadKeystore(cfg *config.C) (libkeystore.Keystore, error) { |
There was a problem hiding this comment.
nit: why not to add this function directly to internal/beatcmd/keystore_nofips.go file?
1pkg
reviewed
Feb 4, 2025
| ) | ||
|
|
||
| // loadKeystore returns the appropriate keystore based on the configuration. | ||
| func loadKeystore(cfg *config.C) (libkeystore.Keystore, error) { |
There was a problem hiding this comment.
nit: why not to add this function directly to internal/beatcmd/keystore_fips.go file?
1pkg
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
the keystore is providing obfuscation of data on disk by using an empty password by default.
This fails in fips only mode with the following error:
crypto/hmac: use of keys shorter than 112 bits is not allowed in FIPS 140-only modeDisable the keystore subcommand and do not try to create one when loading the config.
Checklist
For functional changes, consider:
How to test these changes
Related issues