Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fips): use xxhash for error grouping key in fips mode #15549

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Feb 4, 2025

Motivation/summary

we can't use md5 in a fips environment so switch to xxhash to be consistent with 9.0

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

we can't use md5 in a fips environment so switch to xxhash to
be consistent with 9.0
@kruskall kruskall requested a review from a team as a code owner February 4, 2025 18:24
@kruskall kruskall added the backport-8.18 Automated backport to the 8.18 branch label Feb 4, 2025
@kruskall kruskall merged commit 23b8575 into elastic:8.x Feb 5, 2025
13 checks passed
@kruskall kruskall deleted the feat/fips-grouping-key branch February 5, 2025 13:05
@kruskall
Copy link
Member Author

kruskall commented Feb 5, 2025

@Mergifyio backport 8.18

Copy link
Contributor

mergify bot commented Feb 5, 2025

backport 8.18

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 5, 2025
we can't use md5 in a fips environment so switch to xxhash to
be consistent with 9.0

(cherry picked from commit 23b8575)
mergify bot added a commit that referenced this pull request Feb 5, 2025
…15559)

we can't use md5 in a fips environment so switch to xxhash to
be consistent with 9.0

(cherry picked from commit 23b8575)

Co-authored-by: kruskall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.18 Automated backport to the 8.18 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants