feat(fips): add apm-server-fips target and refactor make build task #16015
+34
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add apm-server-fips with CGO enabled and requirefips tag fix make apm-server on windows fix building windows binary on non-windows GOOS use consistent build args for oss and fips build command
kruskall
added
backport-8.x
build apm-server-bin then rename it to the actual os-specific name
kruskall
commented
Mar 5, 2025
| apm-server-fips: CGO_ENABLED=1 | ||
| apm-server apm-server-oss: CGO_ENABLED=0 | ||
|
|
||
| apm-server-fips: GOTAGS=-tags=requirefips |
There was a problem hiding this comment.
for now a fips build is only passing -tags=requirefips.
GODEBUG/GOFIPS/etc. are coming in a followup PR
make won't rerun a prerequisite each time if multiple targets are passed and they depend on the same target
make won't rerun a prerequisite each time if multiple targets are passed and they depend on the same target
1pkg
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
add apm-server-fips with CGO enabled and requirefips tag
fix make apm-server on windows
fix building windows binary on non-windows GOOS
use consistent build args for oss and fips build command
bonus: you can now pass any GOOS/GOARCH to
make apm-serverto build on any platform supported by golangChecklist
For functional changes, consider:
How to test these changes
fips target:
non-fips targets:
packaging targets:
Related issues
Related to #15876