-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fips): enforce requirements for fips mode #16031
base: main
Are you sure you want to change the base?
Conversation
enforce fips140=only in fips mode enforce -tags=requirefips in fips mode
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
//go:debug lines can only be in main packages
mmh, the godebug issue should be fixed in go 1.24.1 |
package fips140 | ||
|
||
func CheckFips() { | ||
// all good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we actually panic if !cryptofips.Enabled()
here?
import cryptofips "crypto/fips140" | ||
|
||
func CheckFips() { | ||
if cryptofips.Enabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to panic if fips is not required but was enabled anyway?
Motivation/summary
enforce fips140=only in fips mode
enforce -tags=requirefips in fips mode
Checklist
For functional changes, consider:
How to test these changes
Related issues