-
Notifications
You must be signed in to change notification settings - Fork 530
model: change Host.IP to an array #6694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ECS states that this field is an array.
1484024
to
4ca999a
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
ECS states that this field is an array. (cherry picked from commit fbb6167)
ECS states that this field is an array. (cherry picked from commit fbb6167) Co-authored-by: Andrew Wilkins <[email protected]>
Verified with 9bb5e4c: $ curl -H "Content-type: application/x-ndjson" --data-binary @testdata/intake-v2/transactions.ndjson http://localhost:8200/intake/v2/events GET traces-apm*/_search
{
"_source": [false],
"fields": ["host.ip"],
"query": {
"exists": {
"field": "host.ip"
}
}
} {
"took" : 840,
"timed_out" : false,
"_shards" : {
"total" : 2,
"successful" : 2,
"skipped" : 0,
"failed" : 0
},
"hits" : {
"total" : {
"value" : 5,
"relation" : "eq"
},
"max_score" : 1.0,
"hits" : [
{
"_index" : ".ds-traces-apm-default-2021.12.21-000001",
"_id" : "gDPr230ByDpadNqDk0pg",
"_score" : 1.0,
"_source" : { },
"fields" : {
"host.ip" : [
"127.0.0.1"
]
}
},
{
"_index" : ".ds-traces-apm-default-2021.12.21-000001",
"_id" : "gTPr230ByDpadNqDk0pg",
"_score" : 1.0,
"_source" : { },
"fields" : {
"host.ip" : [
"127.0.0.1"
]
}
},
{
"_index" : ".ds-traces-apm-default-2021.12.21-000001",
"_id" : "gjPr230ByDpadNqDk0pg",
"_score" : 1.0,
"_source" : { },
"fields" : {
"host.ip" : [
"127.0.0.1"
]
}
},
{
"_index" : ".ds-traces-apm-default-2021.12.21-000001",
"_id" : "gzPr230ByDpadNqDk0pg",
"_score" : 1.0,
"_source" : { },
"fields" : {
"host.ip" : [
"127.0.0.1"
]
}
},
{
"_index" : ".ds-traces-apm-default-2021.12.21-000001",
"_id" : "hDPr230ByDpadNqDk0pg",
"_score" : 1.0,
"_source" : { },
"fields" : {
"host.ip" : [
"127.0.0.1"
]
}
}
]
}
} It is also displayed correctly in the APM UI: |
Motivation/summary
ECS states that
host.ip
should hold an array of values. Let's align with ECS before we settle on a stable encoding.Checklist
- [ ] Update package changelog.yml (only if changes toapmpackage
have been made)How to test these changes
host.ip
should be rendered sensibly in the flyout in the UIhost.ip
should be an array (even if there's just one IP).Related issues
#4120