Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destination spec #435

Merged
merged 6 commits into from
Apr 27, 2021
Merged

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Apr 20, 2021

The goal of this PR is to document the status quo. So it mainly converts #180 into a proper spec. Additionally, describes the ES mapping, what the fields are used for, and discusses considerations around cardinality.

I think there's potential to simplify destination handling, which is especially needed when we want to open it up to users to set the destination in #424.
We may brainstorm some of the potential simplifications in this PR but I want to strictly separate documenting the status quo from any enhancements.

For example, as destination.service.name and destination.service.type are not used, and as there are no immediate plans (AFAIK) to use them, we might want to consider dropping them in the future.
Another thing to think about is whether we can auto-fill the destination fields based on other properties.
See also #424 (comment)

@apmmachine
Copy link

apmmachine commented Apr 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by timer

  • Start Time: 2021-04-26T04:57:00.770+0000

  • Duration: 3 min 55 sec

  • Commit: f5e5a20

Trends 🧪

Image of Build Times

specs/agents/tracing-spans-destination.md Outdated Show resolved Hide resolved
specs/agents/tracing-spans-destination.md Outdated Show resolved Hide resolved
specs/agents/tracing-spans-destination.md Outdated Show resolved Hide resolved
specs/agents/tracing-spans-destination.md Outdated Show resolved Hide resolved
@felixbarny felixbarny requested a review from axw April 22, 2021 15:12
specs/agents/tracing-spans-destination.md Outdated Show resolved Hide resolved
specs/agents/tracing-spans-destination.md Outdated Show resolved Hide resolved
@AlexanderWert
Copy link
Member

Can we somehow cover the following scenario within this SPEC, that would us allow for corresponding visualization in the UI in the future:

What if a resource provides different ways of accessing it? For instance Azure's CosmosDB allows usage through an SQL API, MongoDB API, Cassandra API, Table API, etc. Similar with AWS' DocumentDB, and there are for sure more examples.

In this case the resource is the actual cloud service (e.g. CosmosDB) but the service type is the access layer (e.g. MongoDB API).

@felixbarny
Copy link
Member Author

I'd see that as an enhancement of the spec and would like to not include it in the first version. Also, does the client even know it's not talking to MongoDB but a MongoDB API-compatible service? To which length would we want to go (such as making a query for a metadata table) in order to detect that?

@felixbarny felixbarny marked this pull request as ready for review April 26, 2021 11:02
@felixbarny felixbarny requested review from a team as code owners April 26, 2021 11:02
@AlexanderWert AlexanderWert self-requested a review April 27, 2021 13:10
@felixbarny
Copy link
Member Author

Merging now as it just documents the status quo and we have a good number of approvals already. Feel free to either comment on this PR or create a follow-up PR if there's more to discuss.

@felixbarny felixbarny merged commit 3f02b1d into elastic:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants