Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB Spec Ambiguites #466

Merged
merged 3 commits into from
Dec 6, 2021
Merged

DynamoDB Spec Ambiguites #466

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
780b27b
fix: DynamoDB edge cases.
Jul 6, 2021
0751e61
fix: updates from feedback
Jul 14, 2021
6793016
Merge branch 'master' into astorm/dynamodb-edge-cases
astorm Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specs/agents/tracing-instrumentation-db.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ The following fields are relevant for database and datastore spans. Where possib

| Field | Value / Examples | Comments |
|-------|:---------------:|----------|
|`name`| e.g. `DynamoDB UpdateItem my_table`| The span name should capture the operation name (as used by AWS for the action name) and the table name, if available. The format should be `DynamoDB <ActionName> <TableName>`. |
|`name`| e.g. `DynamoDB UpdateItem my_table`| The span name should capture the operation name (as used by AWS for the action name) and the table name, if available. The format should be `DynamoDB <ActionName> <TableName>`. TableName MAY be omitted from the name for operations (`batchWriteItem`, `batchGetItem`, PartiQL-related methods like `executeStatement` etc.) that are acting on more than a single table. If `TableName` is not available, agents SHOULD also check the `TableArn` or `SourceTableArn` query params for a table name and extract the table name from the AWS ARN value.|
|`type`|`db`|
|`subtype`|`dynamodb`|
|`action`| `query` |
| __**context.db._**__ |<hr/>|<hr/>|
|`_.instance`| e.g. `us-east-1` | The AWS region where the table is. |
|`_.statement`| e.g. `ForumName = :name and Subject = :sub` | For a DynamoDB Query operation, capture the KeyConditionExpression in this field. |
|`_.statement`| e.g. `ForumName = :name and Subject = :sub` | For a DynamoDB Query operation, capture the KeyConditionExpression in this field. In order to avoid a high cardinality of collected values, agents SHOULD NOT include the full SQL statment for PartiQL-related methods like `executeStatment.|
trentm marked this conversation as resolved.
Show resolved Hide resolved
|`_.type`|`dynamodb`|
|`_.user`| :heavy_minus_sign: |
|`_.link`| :heavy_minus_sign: |
Expand Down