-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch_capture_body_urls option #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quick update! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this Felix!
Co-authored-by: Felix Barnsteiner <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
@felixbarny Are you okay with me changing that "Closes" to "Refs", so that the former issue isn't actually closed when this spec goes in? The issue should be closed when we implement the spec. Update: Oh, actually, I think what's wanted is:
|
As this affects all agents at least in the way the default behaves, I have created implementation issues for all agents and I'm waiting two more days for objections. |
Refs: elastic/apm-agent-nodejs#2019
Closes: #665
We're only expecting to implement this in the Node.js agent in the near future.
Other agents may add this to their roadmap as they see fit but we won't create a cross-agent tracking issue.
sanitize_field_names
) We're only capturing the request body for search requests by default to minimize the risk. Users can also add a custom ingest node pipeline to parse and redact JSON if needed.CODEOWNERS
)/schedule 2022-08-18