-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #29031 #30197
Revert #29031 #30197
Conversation
This revert the code of the APM Instrumentation of the Elastic Agent. To unblock the build of and the CI for other team. This would require more investigation to really understand the problem. Fixes elastic/fleet-server#1129
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request does not have a backport label. Could you fix it @ph? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@kvch Adding you to this PR as well, because when I've reverted the code for the instrumentation I had conflict with the configuration loading change. |
@michel-laterman I've fixed a linter issue from the diagnostic command, can you take a look at this specific part? |
@simitt fyi, I will check tomorrow with Stuart, but let's unblock people for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and it does fix the issue.
* Revert #29031 This revert the code of the APM Instrumentation of the Elastic Agent. To unblock the build of and the CI for other team. This would require more investigation to really understand the problem. Fixes elastic/fleet-server#1129 * fix make update * fix linter (cherry picked from commit 718c923)
Co-authored-by: Pier-Hugues Pellerin <[email protected]>
This reverts commit 718c923.
This reverts commit 718c923.
This reverts commit 718c923.
This revert the code #29031 of the APM Instrumentation of the Elastic Agent.
To unblock the build of and the CI for other team. This would require
more investigation to really understand the problem.
Fixes elastic/fleet-server#1129
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs