Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update docker.io/library/golang docker tag to v1.23.1 #8018

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

elastic-renovate-prod[bot]
Copy link
Contributor

@elastic-renovate-prod elastic-renovate-prod bot commented Aug 19, 2024

This PR (initially opened by Renovate) contains the following updates:

  • docker.io/library/golang to v1.23.1, (used to build the binary in Docker for the final images)

  • cloud-k8s-operator/buildkite-agent to 16a56a1d, (used to test, build, lint in other ci steps), in order to update

    • go to v1.23.1
    • golangci-lint to v1.61.0

Important changes following the golangci-lint update:

  • 43429bd Remove/rename deprecated linters
  • dc505e9 Refactoring for "legitimate" linter warnings
  • a893693 Disable noisy warnings
  • c835d33 Remove returned result value always empty

@elastic-renovate-prod elastic-renovate-prod bot added the >renovate PRs created by or relating to Renovate label Aug 19, 2024
@elastic-renovate-prod elastic-renovate-prod bot force-pushed the renovate/docker.io-library-golang-1.x branch from 0820862 to ccd778c Compare August 28, 2024 09:12
@elastic-renovate-prod elastic-renovate-prod bot changed the title chore(deps): update docker.io/library/golang docker tag to v1.23.0 chore(deps): update docker.io/library/golang docker tag to v1.23.1 Sep 7, 2024
@elastic-renovate-prod elastic-renovate-prod bot force-pushed the renovate/docker.io-library-golang-1.x branch from ccd778c to ef5d780 Compare September 7, 2024 03:01
@elastic-renovate-prod
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@thbkrkr
Copy link
Contributor

thbkrkr commented Sep 27, 2024

buildkite test this

@thbkrkr
Copy link
Contributor

thbkrkr commented Sep 27, 2024

I think the last 4 commits deserve another look. Thanks in advance.

@thbkrkr thbkrkr requested a review from barkbay September 27, 2024 14:39
@@ -15,11 +15,19 @@ linters-settings:
# put imports beginning with prefix after 3rd-party packages;
local-prefixes: github.com/elastic/cloud-on-k8s

gosec:
excludes:
- G115 # potential integer overflow when converting between integer types
Copy link
Contributor

@barkbay barkbay Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is interesting, I had a quick look and there are indeed some cases where conversion is not needed or maybe dangerous. I would maybe create a follow-up issue with the good first issue label?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thbkrkr
Copy link
Contributor

thbkrkr commented Oct 1, 2024

buildkite test this

@thbkrkr thbkrkr enabled auto-merge (squash) October 1, 2024 09:00
@thbkrkr thbkrkr merged commit 69a8b63 into main Oct 1, 2024
5 checks passed
@thbkrkr thbkrkr deleted the renovate/docker.io-library-golang-1.x branch October 1, 2024 09:20
@thbkrkr thbkrkr added the exclude-from-release-notes Exclude this PR from appearing in the release notes label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-release-notes Exclude this PR from appearing in the release notes >renovate PRs created by or relating to Renovate v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants