-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update docker.io/library/golang docker tag to v1.23.1 #8018
Conversation
0820862
to
ccd778c
Compare
ccd778c
to
ef5d780
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
buildkite test this |
I think the last 4 commits deserve another look. Thanks in advance. |
@@ -15,11 +15,19 @@ linters-settings: | |||
# put imports beginning with prefix after 3rd-party packages; | |||
local-prefixes: github.com/elastic/cloud-on-k8s | |||
|
|||
gosec: | |||
excludes: | |||
- G115 # potential integer overflow when converting between integer types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is interesting, I had a quick look and there are indeed some cases where conversion is not needed or maybe dangerous. I would maybe create a follow-up issue with the good first issue
label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildkite test this |
This PR (initially opened by Renovate) contains the following updates:
docker.io/library/golang
tov1.23.1
, (used to build the binary in Docker for the final images)cloud-k8s-operator/buildkite-agent
to16a56a1d
, (used to test, build, lint in other ci steps), in order to updatego
tov1.23.1
golangci-lint
tov1.61.0
Important changes following the golangci-lint update: