Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand extraction service to more connectors #4 #1698

Merged
merged 15 commits into from
Sep 29, 2023

Conversation

navarone-feekery
Copy link
Contributor

@navarone-feekery navarone-feekery commented Sep 28, 2023

Related to https://github.com/elastic/enterprise-search-team/issues/5857

  • Expand extraction service to more connectors:
    • github
    • outlook
    • sharepoint server
    • zoom

Review notes:
There are also a few small bug fixes and removal of obsolete code in this PR, which has added many files to the diff.
For connectors that aren't in the list above, the only changes should be removal of obsolete code or small bug fixes.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference

Related Pull Requests

@navarone-feekery navarone-feekery force-pushed the navarone/5857-expand-extraction-service-4 branch from 671ec9b to 9e60c66 Compare September 29, 2023 08:04
@navarone-feekery navarone-feekery marked this pull request as ready for review September 29, 2023 08:07
@navarone-feekery navarone-feekery requested a review from a team September 29, 2023 08:07
Copy link
Contributor

@vidok vidok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@navarone-feekery navarone-feekery enabled auto-merge (squash) September 29, 2023 09:40
@navarone-feekery navarone-feekery merged commit a9c9042 into main Sep 29, 2023
@navarone-feekery navarone-feekery deleted the navarone/5857-expand-extraction-service-4 branch September 29, 2023 09:54
@leonmeijer
Copy link

Any plans for the network drive connector?

@danajuratoni
Copy link
Contributor

Hi @leonmeijer, adding Extraction Service support for Network Drive is on the roadmap, but not the immediate roadmap. Here's a ticket you can follow for progress or you can even give customizing the connector a try and add support as a community member. Community contributions would be amazing!

@pezzking
Copy link

pezzking commented Feb 8, 2024

we are also desperately waiting for the network drive external extraction support, hoping you would give more priority to this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants