-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dto for page blog documents to access fields in safe manner #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
previously approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚢
jedrazb
reviewed
Nov 20, 2024
jedrazb
approved these changes
Nov 20, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jedrazb
added a commit
that referenced
this pull request
Nov 22, 2024
…nner (#2984) (#2987) Co-authored-by: Artem Shelkovnikov <[email protected]> Co-authored-by: Jedr Blaszyk <[email protected]>
artem-shelkovnikov
added a commit
that referenced
this pull request
Nov 22, 2024
…nner (#2984) (#2988) Co-authored-by: Jedr Blaszyk <[email protected]>
artem-shelkovnikov
added a commit
that referenced
this pull request
Nov 25, 2024
…ner (#2984) (#2986) Co-authored-by: Artem Shelkovnikov <[email protected]> Co-authored-by: Jedr Blaszyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to replace unsafe object field access with safe one - we've received reports with errors coming from these lines because some intermediate objects were None:
Checklists
Pre-Review Checklist
config.yml.example
)v7.13.2
,v7.14.0
,v8.0.0
)Release Note
Fix Confluence connector not downloading some blog post documents due to unexpected response format.