[New connector] Onelake connector #3057
Draft
+935
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onelake connector)
|
|
||
| for path in doc_paths: | ||
| file_name = path.name.split("/")[-1] | ||
| field_client = await self._get_file_client(file_name) |
There was a problem hiding this comment.
Looking at the code, for each file multiple clients are created. Is there a way to reuse the clients between calls? I can see how this can become a problem with RAM
Comment on lines
+92
to
+99
| def _get_account_url(self): | ||
| """Get the account URL for OneLake | ||
|
|
||
| Returns: | ||
| str: Account URL | ||
| """ | ||
|
|
||
| return f"https://{self.configuration['account_name']}.dfs.fabric.microsoft.com" |
There was a problem hiding this comment.
This can just become an field of the class that's set during init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE: [New connector] Onelake connector
Closes #3051
Added Onelake connector files, the connector’s code, test, requirements and the reference to the connector in the sources list (connectors/config.py)
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)