Set connector status to CONNECTED after successful validation and ping #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-shelkovnikov
changed the title
navarone-feekery
approved these changes
Dec 26, 2024
Comment on lines
+38
to
+39
| if self.reusable: | ||
| self.i = 0 |
There was a problem hiding this comment.
I can see it's only for tests so not a big deal but does this open a risk for infinite looping anywhere?
There was a problem hiding this comment.
It should not be, no. Here there's no return statement, so next line that raises an error will be triggered and iterations will stop. Next time this iterator is used it's going to be iterating over same original collection, before it would immediately stop iteration.
artem-shelkovnikov
deleted the
artem/reset-connector-status-after-successful-ping
branch
artem-shelkovnikov
added a commit
that referenced
this pull request
Dec 27, 2024
…and ping (#3059) (#3060) Co-authored-by: Artem Shelkovnikov <[email protected]>
artem-shelkovnikov
added a commit
that referenced
this pull request
Dec 27, 2024
…nd ping (#3059) (#3061) Co-authored-by: Artem Shelkovnikov <[email protected]>
artem-shelkovnikov
added a commit
that referenced
this pull request
Dec 27, 2024
…and ping (#3059) (#3062) Co-authored-by: Artem Shelkovnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3021
Closes https://github.com/elastic/search-team/issues/8535
Currently connectors have no way to report they're connected.
This PR makes it so that if a data source succeeds in validation and ping, then its status is set to CONNECTED.
In practice it means, that a user who had problems with their setup will see an error in UI. If they fix the credentials, before the error would go away after a sync starts. After this change the error will disappear within the service poll interval from user's action.
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Release Note
Fix a UI issue with connector reporting problems with connection even if wrong configuration was fixed. Before the error would go away only when a sync is executed.