Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lint step run autoformat and commit changes for you + minor refactoring #3076

Merged
merged 25 commits into from
Jan 8, 2025

Conversation

artem-shelkovnikov
Copy link
Member

@artem-shelkovnikov artem-shelkovnikov commented Jan 7, 2025

This PR attempts to run autoformat if possible on linting stage

Actual changes:

  • If on a branch with a PR, linting stage will run make autoformat and commit changes if it fixes linting failure
  • Notice check now runs first and all other commands wait for it to finish. It's done because both linting and notice check stages can do autofix + push, and it'll cause conflicts and weird job restarts. The wait step ensures we don't run both steps at the same time. This makes CI a bit slower though
  • Cleans up shell scripts a bit to re-use as much code as possible + delete broken/unused code

@artem-shelkovnikov artem-shelkovnikov force-pushed the artem/make-linter-autoformat branch from 24c05c1 to cb3b467 Compare January 7, 2025 13:42
@artem-shelkovnikov artem-shelkovnikov changed the title Artem/make linter autoformat Make lint step run autoformat and commit changes for you + minor refactorings Jan 8, 2025
@artem-shelkovnikov artem-shelkovnikov changed the title Make lint step run autoformat and commit changes for you + minor refactorings Make lint step run autoformat and commit changes for you + minor refactoring Jan 8, 2025
@artem-shelkovnikov artem-shelkovnikov marked this pull request as ready for review January 8, 2025 10:18
@artem-shelkovnikov artem-shelkovnikov requested a review from a team as a code owner January 8, 2025 10:18
Copy link
Contributor

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@artem-shelkovnikov artem-shelkovnikov merged commit d0e91cd into main Jan 8, 2025
2 checks passed
@artem-shelkovnikov artem-shelkovnikov deleted the artem/make-linter-autoformat branch January 8, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants