Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock up ECE installation options #8

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

lcawl
Copy link

@lcawl lcawl commented Nov 28, 2024

This was referenced Nov 28, 2024
@lcawl lcawl marked this pull request as ready for review December 19, 2024 23:10
tar -xzf elasticsearch-{{version}}-linux-x86_64.tar.gz
cd elasticsearch-{{version}}/ <2>
```
<1> Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output
1. Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output

```
<1> Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output
`elasticsearch-{{version}}-linux-x86_64.tar.gz: OK`.
<2> This directory is known as `$ES_HOME`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<2> This directory is known as `$ES_HOME`.
2. This directory is known as `$ES_HOME`.

Comment on lines +44 to +46
<1> Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output
`elasticsearch-{{version}}-darwin-x86_64.tar.gz: OK`.
<2> This directory is known as `$ES_HOME`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output
`elasticsearch-{{version}}-darwin-x86_64.tar.gz: OK`.
<2> This directory is known as `$ES_HOME`.
1. Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output
`elasticsearch-{{version}}-darwin-x86_64.tar.gz: OK`.
2. This directory is known as `$ES_HOME`.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to pull this in to get some more real content @lcawl

Added some suggestions to fix new validation on code callouts:

elastic/docs-builder#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants