Adds video guidance to syntax ref guide#3253
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request adds a new documentation page, docs/syntax/videos.md, and registers it in the docs table of contents (docs/_docset.yml). The new page documents how to embed and link videos, covering Elastic-hosted thumbnail links, YouTube embeds, a best-practices checklist, example Markdown snippets, and a note that video URLs must use lowercase characters for docs-builder compatibility. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/syntax/videos.md`:
- Line 6: The Elastic-hosted example contradicts the "Video link URLs must use
lowercase characters only" rule by using a mixed-case ID in the example URLs;
update the Elastic example so both video link URLs use the lowercase-only ID
(replace the mixed-case ID with its lowercase equivalent in the Elastic-hosted
example) so the guidance and example are consistent.
- Line 53: Update the checklist entry that currently reads "Use lowercase
characters in all video URLs" so it only applies to Elastic/integrations style
paths (e.g., URLs containing "elastic" or "/integrations/") and not to external
provider IDs like YouTube video IDs; change the sentence to explicitly scope
lowercase requirement to Elastic/integrations URL pattern and add a note that
provider IDs (e.g., YouTube IDs) must be left case-sensitive. Also adjust the
related duplicate instances of that checklist text so they match the new scoped
wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 17ab26ba-50e3-43af-9a9c-2560dbb20f0e
📒 Files selected for processing (2)
docs/_docset.ymldocs/syntax/videos.md
benironside
left a comment
There was a problem hiding this comment.
LGTM, syntax is familiar. Not blocking, but the callout about the lowercase URLs is interesting. I haven't tested it but I think making clear exactly what happens with integrations docs if we use video URLs with mixed cases would be helpful.
Resolves elastic/docs-content#5626 by adding guidance on how to add videos to docs.