Closed
Clear capture_message_content env var in programmatic override test#109
Conversation
Co-authored-by: xrmx <12932+xrmx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as per review comment 3774433771
Clear capture_message_content env var in programmatic override test
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_can_override_capture_message_content_programmaticallywas non-deterministic: ifOTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENTwas set in the environment, it would override the programmaticcapture_message_content=Trueargument, causing the assertion to fail or pass for the wrong reason.Changes
tests/test_instrumentor.py: PopOTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENTfrom the environment before callinginstrumentor.instrument(capture_message_content=True), ensuring the test actually validates the programmatic override path regardless of CI/local environment state.