Add profile flag to commands to allow running profiles at the same time #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Jul 25, 2023
Comment on lines
+25
to
+27
| if profile.ProfileName == "default" { | ||
| return baseComposeProjectName | ||
| } |
There was a problem hiding this comment.
If this condition is added, the resulting container names would be the same as previously keeping backwards compatibility.
|
GCP test package is failing, investigating it here #1366 |
jsoriano
approved these changes
Jul 25, 2023
|
/test |
💚 Build Succeeded
History
cc @mrodm |
jsoriano
reviewed
Jul 26, 2023
| @@ -248,6 +251,11 @@ func systemCommandAction(cmd *cobra.Command, args []string) error { | |||
| return fmt.Errorf("locating package root failed: %w", err) | |||
| } | |||
|
|
|||
| profile, err := cobraext.GetProfileFlag(cmd) | |||
| if err != nil { | |||
| return nil | |||
| @@ -58,8 +60,14 @@ func upCommandAction(cmd *cobra.Command, args []string) error { | |||
|
|
|||
| variantFlag, _ := cmd.Flags().GetString(cobraext.VariantFlagName) | |||
|
|
|||
| profile, err := cobraext.GetProfileFlag(cmd) | |||
| if err != nil { | |||
| return nil | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1230
This allows us to use the profile information to be able to start different profiles at the same time. Profile information is used to set a different name for the Docker Compose Project.
This PR also adds profile flag to these commands:
How to test