Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow pipeline test case to define the expected output based on service versions constraints #2114

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Sep 20, 2024

This PR essentially allows to specify a different expected output for a given pipeline test case based on given version constraints of running stack services. Such a feature is required to handle gracefully cases as the one captured here where the normal CI tests are passing as the stack version is defined by the minimum one required by the package manifest. However, testing it with a higher version of the stack, although not required to be the minimum supported, it results in different expected outputs

An example of an integration package that this PR could be used with can be found here. Here we define different expected outputs for test-cisco-ios.log and test-asr920.log depending on the elasticsearch version of the running stack

@pkoutsovasilis pkoutsovasilis force-pushed the pkoutsovasilis/expected_output_version_constraints branch from 8241950 to d2963fd Compare September 21, 2024 05:12
@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review September 21, 2024 06:36
@pkoutsovasilis
Copy link
Contributor Author

cc @qcorporation @gogochan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@jsoriano jsoriano requested a review from a team October 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants